fix(types): make name and values required in onValueChange callback#427
Open
csandman wants to merge 1 commit into
Open
fix(types): make name and values required in onValueChange callback#427csandman wants to merge 1 commit into
csandman wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
onValueChangetypesnameandvaluesas optional (?), but every call site in the source always passes all three arguments — including the empty/clear case, which passesundefinedforvalueand{ float: null, formatted: "", value: "" }forvalues. There is no code path whereonValueChangeis called without all three arguments.What changed
Removed the
?fromnameandvaluesin theonValueChangecallback signature so the types accurately reflect runtime behavior:Why this is not a breaking change
The optional markers were never solving a real problem. JavaScript functions naturally accept fewer arguments than their signature declares — a callback defined as (value) => doSomething(value) can always be passed three arguments without issue. TypeScript reflects this correctly: a function typed as (value: string | undefined) => void is assignable to a callback that passes three arguments, with no changes needed on the consumer side.
Consumers who don't use name or values can continue to omit them from their handler signature. Consumers who do use them no longer need to defensively guard against undefined on arguments that are always present.
Closes #426